clk: Fix memory leak in devm_clk_notifier_register()
authorFei Shao <fshao@chromium.org>
Mon, 19 Jun 2023 03:22:53 +0000 (11:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:33 +0000 (16:21 +0200)
commit49451db71b746df990888068961f1033f7c9b734
tree78d18bacb8e87046abee48f81dc6bf33db529c15
parent03a705c1d7cb9c7dd55a0b96e1fc9ef7c236d35a
clk: Fix memory leak in devm_clk_notifier_register()

[ Upstream commit 7fb933e56f77a57ef7cfc59fc34cbbf1b1fa31ff ]

devm_clk_notifier_register() allocates a devres resource for clk
notifier but didn't register that to the device, so the notifier didn't
get unregistered on device detach and the allocated resource was leaked.

Fix the issue by registering the resource through devres_add().

This issue was found with kmemleak on a Chromebook.

Fixes: 6d30d50d037d ("clk: add devm variant of clk_notifier_register")
Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://lore.kernel.org/r/20230619112253.v2.1.I13f060c10549ef181603e921291bdea95f83033c@changeid
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk.c