usb: gadget: udc: core: Prevent redundant calls to pullup
authorBadhri Jagan Sridharan <badhri@google.com>
Fri, 7 Apr 2023 03:07:41 +0000 (03:07 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:02:59 +0000 (23:02 +0900)
commit491d32c896e05a0fc4d20179f857c1af1f54c618
tree43799647845b62cdb6aa929111116eda25ae9ed7
parentf6aaeacf0596ac2fa869296ace7f85aa960e9e87
usb: gadget: udc: core: Prevent redundant calls to pullup

commit a3afbf5cc887fc3401f012fe629810998ed61859 upstream.

usb_gadget_connect calls gadget->ops->pullup without checking whether
gadget->connected was previously set. Make this symmetric to
usb_gadget_disconnect by returning early if gadget->connected is
already set.

Fixes: 5a1da544e572 ("usb: gadget: core: do not try to disconnect gadget if it is not connected")
Cc: stable@vger.kernel.org
Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
Link: https://lore.kernel.org/r/20230407030741.3163220-2-badhri@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/core.c