of: overlay: validate offset from property fixups
authorFrank Rowand <frank.rowand@sony.com>
Thu, 17 May 2018 04:19:51 +0000 (21:19 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Jul 2018 09:24:52 +0000 (11:24 +0200)
commit4910cc250b4dab82b42a743377d359abaee07b73
tree91fde89183d2bbf698e3956a24da6579d6a30423
parent728ea2302acc19cd83164b38408fd5f84e5153b2
of: overlay: validate offset from property fixups

commit 482137bf2aecd887ebfa8756456764a2f6a0e545 upstream.

The smatch static checker marks the data in offset as untrusted,
leading it to warn:

  drivers/of/resolver.c:125 update_usages_of_a_phandle_reference()
  error: buffer underflow 'prop->value' 's32min-s32max'

Add check to verify that offset is within the property data.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/of/resolver.c