net: qrtr: Avoid potential use after free in MHI send
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 21 Apr 2021 17:40:07 +0000 (10:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 May 2021 09:04:31 +0000 (11:04 +0200)
commit48ec949ac979b4b42d740f67b6177797af834f80
tree4816a43a292f51ce937127fb6e672b413ed3f532
parent2fa15d61e4cbaaa1d1250e67b251ff96952fa614
net: qrtr: Avoid potential use after free in MHI send

commit 47a017f33943278570c072bc71681809b2567b3a upstream.

It is possible that the MHI ul_callback will be invoked immediately
following the queueing of the skb for transmission, leading to the
callback decrementing the refcount of the associated sk and freeing the
skb.

As such the dereference of skb and the increment of the sk refcount must
happen before the skb is queued, to avoid the skb to be used after free
and potentially the sk to drop its last refcount..

Fixes: 6e728f321393 ("net: qrtr: Add MHI transport layer")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/qrtr/mhi.c