coda: Avoid partial allocation of sig_inputArgs
authorKees Cook <keescook@chromium.org>
Fri, 27 Jan 2023 22:39:21 +0000 (14:39 -0800)
committerKees Cook <keescook@chromium.org>
Wed, 8 Feb 2023 23:26:58 +0000 (15:26 -0800)
commit48df133578c70185a95a49390d42df1996ddba2a
treea7956907fe0141e4ed3ec9d552c520259d6d72ae
parent5c0f220e1b2d349b6241375e19887b5c865a84a1
coda: Avoid partial allocation of sig_inputArgs

GCC does not like having a partially allocated object, since it cannot
reason about it for bounds checking when it is passed to other code.
Instead, fully allocate sig_inputArgs. (Alternatively, sig_inputArgs
should be defined as a struct coda_in_hdr, if it is actually not using
any other part of the union.) Seen under GCC 13:

../fs/coda/upcall.c: In function 'coda_upcall':
../fs/coda/upcall.c:801:22: warning: array subscript 'union inputArgs[0]' is partly outside array bounds of 'unsigned char[20]' [-Warray-bounds=]
  801 |         sig_inputArgs->ih.opcode = CODA_SIGNAL;
      |                      ^~

Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: coda@cs.cmu.edu
Cc: codalist@coda.cs.cmu.edu
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230127223921.never.882-kees@kernel.org
fs/coda/upcall.c