Verify memory address range validity in GDBRemoteCommunicationClient
authorStephane Sezer <sas@cd80.net>
Fri, 31 Mar 2017 18:00:48 +0000 (18:00 +0000)
committerStephane Sezer <sas@cd80.net>
Fri, 31 Mar 2017 18:00:48 +0000 (18:00 +0000)
commit48d1427c30b73b7ceef154100c774f753c600e31
tree1875221d4e2820b97f0c3adf721c6f258f2331d5
parent303abb803ae201ebdc040128e0fdf8eab14f5944
Verify memory address range validity in GDBRemoteCommunicationClient

Summary:
This aims to verify the validity of the response from the debugging
server in GDBRemoteCommunicationClient::GetMemoryRegionInfo. I was
working with ds2 (https://github.com/facebook/ds2) and encountered a bug
that caused the server's response to have a 'size' value of 0, which
caused lldb to behave incorrectly.

Reviewers: k8stone, labath, clayborg

Reviewed By: labath, clayborg

Subscribers: clayborg, sas, lldb-commits

Differential Revision: https://reviews.llvm.org/D31485

Change by Alex Langford <apl@fb.com>

llvm-svn: 299239
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp