fpga: bridge: return errors in the show() method of the "state" attribute
authorMarco Pagani <marpagan@redhat.com>
Wed, 25 Jan 2023 14:06:22 +0000 (15:06 +0100)
committerXu Yilun <yilun.xu@intel.com>
Sat, 28 Jan 2023 15:34:06 +0000 (23:34 +0800)
commit48ca6e5fa4ffc40a14fe45bd5499428a5a108a68
treed05ba4665a4c547ee1c7cfc4623fe79a00ad23cc
parenta73c125bbbcf6185b5a77ae946aa240876b4fe71
fpga: bridge: return errors in the show() method of the "state" attribute

This patch changes the show() method of the "state" sysfs attribute to
propagate errors returned by the enable_show() op. In this way,
userspace can distinguish between when the bridge is actually "enabled"
(i.e., allowing signals) or "disabled" (i.e., gating signals), or when
there is an error.

Currently, enable_show() returns an integer representing the bridge's
state (enabled or disabled) or an error code. However, this integer
value is interpreted in state_show() as a bool, resulting in the method
printing "enabled" (i.e., the bridge allows signals to pass), without
propagating the error, even when enable_show() returns an error code.

Signed-off-by: Marco Pagani <marpagan@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20230125140622.176870-1-marpagan@redhat.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
drivers/fpga/fpga-bridge.c