drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak
authorJulia Lawall <julia@diku.dk>
Tue, 31 Aug 2010 15:48:55 +0000 (17:48 +0200)
committerKumar Gala <galak@kernel.crashing.org>
Tue, 15 Mar 2011 18:48:16 +0000 (13:48 -0500)
commit48a10cdfc0262ee7b5ccd4cbb673957e320ec563
tree0b329e6f0d40b997c74c32531a425c9f4906d18d
parentafc0a07d4a283599ac3a6a31d7454e9baaeccca0
drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak

Add a call to of_node_put in the error handling code following a call to
of_find_compatible_node or of_find_node_by_type.

This patch also substantially reorganizes the error handling code in the
function, to that it is possible first to jump to code that frees qe_port
and then to jump to code that also puts np.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression x;
expression E,E1,E2;
statement S;
@@

*x =
(of_find_node_by_path
|of_find_node_by_name
|of_find_node_by_phandle
|of_get_parent
|of_get_next_parent
|of_get_next_child
|of_find_compatible_node
|of_match_node
|of_find_node_by_type
|of_find_node_with_property
|of_find_matching_node
|of_parse_phandle
)(...);
...
if (x == NULL) S
<... when != x = E
*if (...) {
  ... when != of_node_put(x)
      when != if (...) { ... of_node_put(x); ... }
(
  return <+...x...+>;
|
*  return ...;
)
}
...>
(
E2 = x;
|
of_node_put(x);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Timur Tabi <timur@freescale.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
drivers/tty/serial/ucc_uart.c