Add a "signature" to AST files to verify that they haven't changed
authorBen Langmuir <blangmuir@apple.com>
Thu, 23 Oct 2014 18:05:36 +0000 (18:05 +0000)
committerBen Langmuir <blangmuir@apple.com>
Thu, 23 Oct 2014 18:05:36 +0000 (18:05 +0000)
commit487ea14a46f50f7b025ebb3ae5ee00da935b3f25
tree546427f824aec7a61a92e1cf15451afe1ed88ef1
parent5b2787dfb263574ec94a1993c3f1627f9adf97da
Add a "signature" to AST files to verify that they haven't changed

Since the order of the IDs in the AST file (e.g. DeclIDs, SelectorIDs)
is not stable, it is not safe to load an AST file that depends on
another AST file that has been rebuilt since the importer was built,
even if "nothing changed". We previously used size and modtime to check
this, but I've seen cases where a module rebuilt quickly enough to foil
this check and caused very hard to debug build errors.

To save cycles when we're loading the AST, we just generate a random
nonce value and check that it hasn't changed when we load an imported
module, rather than actually hash the whole file.

This is slightly complicated by the fact that we need to verify the
signature inside addModule, since we might otherwise consider that a
mdoule is "OutOfDate" when really it is the importer that is out of
date. I didn't see any regressions in module load time after this
change.

llvm-svn: 220493
clang/include/clang/Serialization/ASTBitCodes.h
clang/include/clang/Serialization/ASTReader.h
clang/include/clang/Serialization/Module.h
clang/include/clang/Serialization/ModuleManager.h
clang/lib/Serialization/ASTReader.cpp
clang/lib/Serialization/ASTWriter.cpp
clang/lib/Serialization/GlobalModuleIndex.cpp
clang/lib/Serialization/Module.cpp
clang/lib/Serialization/ModuleManager.cpp
clang/test/Modules/rebuild.m [new file with mode: 0644]