fix infinite loops and remove public apis (#5954)
authorShane Neuville <shane94@hotmail.com>
Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)
committerGitHub <noreply@github.com>
Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)
commit48606a5f1fad511e1fa839469fa3b1d4092dcc63
tree6406235796cd0327e5c33c621200135207d38b16
parent583be22d5ce7dc9a6b980adb8fec8b9077a7a314
fix infinite loops and remove public apis (#5954)

* fix infinite loops and remove public apis

* - remove comments, fix location to not have implicit

* force uri to be relative on ios when no scheme specified

* address PR comments

* add error message

* reformat absolute uris

* additional suggestions

* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
Xamarin.Forms.Core.UnitTests/ShellTestBase.cs
Xamarin.Forms.Core.UnitTests/ShellTests.cs
Xamarin.Forms.Core.UnitTests/ShellUriHandlerTests.cs
Xamarin.Forms.Core/Routing.cs
Xamarin.Forms.Core/Shell/IShellItemController.cs
Xamarin.Forms.Core/Shell/IShellSectionController.cs
Xamarin.Forms.Core/Shell/Shell.cs
Xamarin.Forms.Core/Shell/ShellItem.cs
Xamarin.Forms.Core/Shell/ShellNavigationState.cs
Xamarin.Forms.Core/Shell/ShellSection.cs
Xamarin.Forms.Core/Shell/ShellUriHandler.cs