Check m_dyld_up directly in LoadBinariesViaMetadata
authorJason Molenda <jason@molenda.com>
Thu, 10 Nov 2022 23:46:32 +0000 (15:46 -0800)
committerJason Molenda <jason@molenda.com>
Thu, 10 Nov 2022 23:49:23 +0000 (15:49 -0800)
commit48321eea9679e1d8c5a30f4027e1aa49738aebf3
treef7e5df3062a7fbace4bacf80d4c0139ebdcc17d9
parente66d79e5154cb1a90fd34c2f0d530bf77c1c59ab
Check m_dyld_up directly in LoadBinariesViaMetadata

In the restructuring I did in https://reviews.llvm.org/D133680 , I
call ObjectFile::LoadBinariesViaMetadata, and the process m_dyld
may be set by a method under there -- in
ProcessMachCore::LoadBinariesViaMetadata I wanted to check to see
if m_dyld_up had been set.  I did this by calling the GetDynamicLoader()
method, but that method will call FindPlugin() if there is no
dynamic loader yet, and the static dynamic loader plugin was being
loaded, preventing the scan for userland binaries in a userland
corefile.

Differential Revision: https://reviews.llvm.org/D137807
rdar://102210820
lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp