x86/fpu/xstate: Fix XSTATE_WARN_ON() to emit relevant diagnostics
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 10 Aug 2022 22:19:09 +0000 (23:19 +0100)
committerBorislav Petkov <bp@suse.de>
Wed, 9 Nov 2022 12:28:31 +0000 (13:28 +0100)
commit48280042f2c6e3ac2cfb1d8b752ab4a7e0baea24
treeb1e33fc81bb26327c0f5eedf485db68cb5012164
parentf0c4d9fc9cc9462659728d168387191387e903cc
x86/fpu/xstate: Fix XSTATE_WARN_ON() to emit relevant diagnostics

"XSAVE consistency problem" has been reported under Xen, but that's the extent
of my divination skills.

Modify XSTATE_WARN_ON() to force the caller to provide relevant diagnostic
information, and modify each caller suitably.

For check_xstate_against_struct(), this removes a double WARN() where one will
do perfectly fine.

CC stable as this has been wonky debugging for 7 years and it is good to
have there too.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220810221909.12768-1-andrew.cooper3@citrix.com
arch/x86/kernel/fpu/xstate.c