Revert D130308 "[clang] extend getCommonSugaredType to merge sugar nodes"
authorFangrui Song <i@maskray.me>
Thu, 8 Sep 2022 22:09:39 +0000 (15:09 -0700)
committerFangrui Song <i@maskray.me>
Thu, 8 Sep 2022 22:09:39 +0000 (15:09 -0700)
commit48203b327d8ddf2cb785a1ac30b3cd9fa1e54b44
tree761097f53074efb89c2c1315f5efc93571961df7
parent1a6ffd77816350b546d0eff680d678f9ca6108de
Revert D130308 "[clang] extend getCommonSugaredType to merge sugar nodes"

This reverts commit 16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359.
There are multiple complaints on the review.

In addition, it may cause spurious
```
error: invalid operands to binary expression ('SinkPrinter' and 'char[cluster_name_length]')
note: candidate template ignored: substitution failure: variably modified type 'char *' cannot be used as a template argument SinkPrinter operator<<(const SinkPrinter &s, T) {
```
for some C++ code
clang/include/clang/AST/ASTContext.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaTemplateDeduction.cpp
clang/test/SemaCXX/sugar-common-types.cpp