projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 80e14d7) | patch
lib: allow server.listen({ port: "1234" })
authorBen Noordhuis <info@bnoordhuis.nl>
Tue, 10 Mar 2015 11:33:38 +0000 (12:33 +0100)
committerBen Noordhuis <info@bnoordhuis.nl>
Tue, 10 Mar 2015 15:13:29 +0000 (16:13 +0100)
commit480b48244f14d64d6361c4b8e9bb3e479b5f7fa1
treedf96e60508ce15d71b35ad5e66c1cfd0efdb4f79tree | snapshot
parent80e14d736ed6aaffcfbf5766a8ec36464401d91acommit | diff
lib: allow server.listen({ port: "1234" })

net.connect() accepts `{ port: "1234" }` (i.e. a string) as of commit
9d2b89d06 ("net: allow port 0 in connect()") but net.Server#listen()
did not, creating a minor inconsistency.  This commit rectifies that.

Fixes: https://github.com/iojs/io.js/issues/1111
PR-URL: https://github.com/iojs/io.js/pull/1116
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
lib/net.js diff | blob | history
test/parallel/test-net-listen-port-option.js [new file with mode: 0644] blob
Domain: Web Framework / Common;