media: subdev: Don't report V4L2_SUBDEV_CAP_STREAMS when the streams API is disabled
authorHans de Goede <hdegoede@redhat.com>
Tue, 10 Oct 2023 10:24:58 +0000 (12:24 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 11 Oct 2023 12:52:57 +0000 (14:52 +0200)
commit4800021c630210ea0b19434a1fb56ab16385f2b3
treeeb16780a70e22e2c56ae52fb8909b99ef575c0b4
parent10a6e5feccb877c3c75ad11d27942ad52c24815f
media: subdev: Don't report V4L2_SUBDEV_CAP_STREAMS when the streams API is disabled

Since the stream API is still experimental it is currently locked away
behind the internal, default disabled, v4l2_subdev_enable_streams_api flag.

Advertising V4L2_SUBDEV_CAP_STREAMS when the streams API is disabled
confuses userspace. E.g. it causes the following libcamera error:

ERROR SimplePipeline simple.cpp:1497 Failed to reset routes for
  /dev/v4l-subdev1: Inappropriate ioctl for device

Don't report V4L2_SUBDEV_CAP_STREAMS when the streams API is disabled
to avoid problems like this.

Reported-by: Dennis Bonke <admin@dennisbonke.com>
Fixes: 9a6b5bf4c1bb ("media: add V4L2_SUBDEV_CAP_STREAMS")
Cc: stable@vger.kernel.org # for >= 6.3
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/v4l2-core/v4l2-subdev.c