HID: mcp-2221: prevent UAF in delayed work
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Thu, 16 Feb 2023 10:22:58 +0000 (11:22 +0100)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Mon, 20 Feb 2023 09:21:01 +0000 (10:21 +0100)
commit47e91fdfa511139f2549687edb0d8649b123227b
tree1b001c5f5c7d3719e04ef278cbd1b9ff27b35d50
parent0b028189d1019ca352da108643b8f1503ee25a0e
HID: mcp-2221: prevent UAF in delayed work

If the device is plugged/unplugged without giving time for mcp_init_work()
to complete, we might kick in the devm free code path and thus have
unavailable struct mcp_2221 while in delayed work.

Canceling the delayed_work item is enough to solve the issue, because
cancel_delayed_work_sync will prevent the work item to requeue itself.

Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
CC: stable@vger.kernel.org
Acked-by: Jiri Kosina <jkosina@suse.cz>
Link: https://lore.kernel.org/r/20230215-wip-mcp2221-v2-1-109f71fd036e@redhat.com
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-mcp2221.c