dm: fix potential for q->make_request_fn NULL pointer
authorMike Snitzer <snitzer@redhat.com>
Mon, 27 Jan 2020 19:07:23 +0000 (14:07 -0500)
committerMike Snitzer <snitzer@redhat.com>
Mon, 27 Jan 2020 19:52:36 +0000 (14:52 -0500)
commit47ace7e012b9f7ad71d43ac9063d335ea3d6820b
tree2b45907e46c5531c2fb824a68ad4aa5b63ce0f5c
parentdcd195071f22d4770911ca46694ca398b6d5101d
dm: fix potential for q->make_request_fn NULL pointer

Move blk_queue_make_request() to dm.c:alloc_dev() so that
q->make_request_fn is never NULL during the lifetime of a DM device
(even one that is created without a DM table).

Otherwise generic_make_request() will crash simply by doing:
  dmsetup create -n test
  mount /dev/dm-N /mnt

While at it, move ->congested_data initialization out of
dm.c:alloc_dev() and into the bio-based specific init method.

Reported-by: Stefan Bader <stefan.bader@canonical.com>
BugLink: https://bugs.launchpad.net/bugs/1860231
Fixes: ff36ab34583a ("dm: remove request-based logic from make_request_fn wrapper")
Depends-on: c12c9a3c3860c ("dm: various cleanups to md->queue initialization code")
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm.c