leds: wm831x-status: fix use-after-free on unbind
authorJohan Hovold <johan@kernel.org>
Mon, 1 Jun 2020 13:39:49 +0000 (15:39 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 22 Jun 2020 08:38:00 +0000 (10:38 +0200)
commit47a459ecc800a17109d0c496a4e21e478806ee40
tree5e2cfb6318dd2c73b0e6b3d618611da8a41e8f1c
parenta0972fff09479dd09b731360a3a0b09e4fb4d415
leds: wm831x-status: fix use-after-free on unbind

Several MFD child drivers register their class devices directly under
the parent device. This means you cannot blindly do devres conversions
so that deregistration ends up being tied to the parent device,
something which leads to use-after-free on driver unbind when the class
device is released while still being registered.

Fixes: 8d3b6a4001ce ("leds: wm831x-status: Use devm_led_classdev_register")
Cc: stable <stable@vger.kernel.org> # 4.6
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-wm831x-status.c