drm/atomic-helper: Don't call atomic_update_plane when it stays off
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 10 Apr 2015 14:22:39 +0000 (16:22 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 16 Apr 2015 07:50:27 +0000 (09:50 +0200)
commit475d231be9bae4b997eb7e5a9a3cb214259cf90a
treed4b9e236229e80cd0b69a22ab3d9670e753f7d30
parent2b1193d5287004edfbf89407149a3159656f47f1
drm/atomic-helper: Don't call atomic_update_plane when it stays off

It's a silly thing to do and surprises driver writers. Most likely
this did already blow up for exynos.

It's also a silly thing to change plane state when it's off, but fbdev
is silly (it does an unconditional modeset over all planes). And
userspace can be evil. So I think we need this.

With this check in the helpers we can remove the one in i915 code for
the same conditions (becuase ->crtc iff ->fb).

Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: dri-devel@lists.freedesktop.org
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
drivers/gpu/drm/drm_atomic_helper.c
drivers/gpu/drm/i915/intel_atomic_plane.c