Merge pull request #19392 from amirtu:OCV-165_finalize_goodFeaturesToTrack_returns_al...
authorAmir Tulegenov <amir.tulegen@gmail.com>
Mon, 15 Feb 2021 19:55:57 +0000 (01:55 +0600)
committerGitHub <noreply@github.com>
Mon, 15 Feb 2021 19:55:57 +0000 (19:55 +0000)
commit47426a8ae5d11296bdb759698dd6bd8934d6377a
tree9aea391e4cc246e3b9313a3027bba01c11538e23
parentad66b070a7e91d48d15311f925791de1e8ba96fb
Merge pull request #19392 from amirtu:OCV-165_finalize_goodFeaturesToTrack_returns_also_corner_value_PR

* goodFeaturesToTrack returns also corner value

(cherry picked from commit 4a8f06755cf93785a82a455a2035a2ff572cafae)

* Added response to GFTT Detector keypoints

(cherry picked from commit b88fb40c6ea037e5283e4fbcf0ffde160c65a035)

* Moved corner values to another optional variable to preserve backward compatibility

(cherry picked from commit 6137383d32859efad7b44dd8a798e7b69f68dec5)

* Removed corners valus from perf tests and better unit tests for corners values

(cherry picked from commit f3d0ef21a78b7d0dc8696c457a6fabecfbe5e8ff)

* Fixed detector gftt call

(cherry picked from commit be2975553ba01a7d2e63f549fadccec6d7d56797)

* Restored test_cornerEigenValsVecs

(cherry picked from commit ea3e11811faee63487449983c0b80ff8ee35bbac)

* scaling fixed;
mineigen calculation rolled back;
gftt function overload added (with quality parameter);
perf tests were added for the new api function;
external bindings were added for the function (with different alias);
fixed issues with composition of the output array of the new function (e.g. as requested in comments) ;
added sanity checks in the perf tests;
removed C API changes.

* minor change to GFTTDetector::detect

* substitute ts->printf with EXPECT_LE

* avoid re-allocations

Co-authored-by: Anas <anas.el.amraoui@live.com>
Co-authored-by: amir.tulegenov <amir.tulegenov@xperience.ai>
modules/features2d/src/gftt.cpp
modules/imgproc/include/opencv2/imgproc.hpp
modules/imgproc/perf/opencl/perf_gftt.cpp
modules/imgproc/perf/perf_goodFeaturesToTrack.cpp
modules/imgproc/src/featureselect.cpp
modules/imgproc/test/ocl/test_gftt.cpp
modules/imgproc/test/test_goodfeaturetotrack.cpp