Use scoped_free_pendings in coff_symtab_read
authorTom Tromey <tom@tromey.com>
Fri, 29 Jun 2018 21:10:04 +0000 (15:10 -0600)
committerTom Tromey <tom@tromey.com>
Tue, 17 Jul 2018 15:30:57 +0000 (09:30 -0600)
commit4735f0edf4265e3e260e10a12921baf17987a020
tree604964b377908123bd4150079aeec3dc10611365
parent0909f342a21207c0b096e8caa7462b1c6809298e
Use scoped_free_pendings in coff_symtab_read

PR gdb/18624 concerns an assertion failure that occurs when setting a
breakpoint in a Go program on Windows.

What happens here is that coff_symtab_read uses buildsym but does not
instantiate scoped_free_pendings.  So, the struct pending objects are
never released.  Later, dwarf2read.c calls buildsym_init, which
asserts.

This patch fixes the problem by instantiating scoped_free_pendings in
coff_symtab_read.

Tested using the test executable from the PR.  I don't know how to
test this more fully.

gdb/ChangeLog
2018-07-17  Tom Tromey  <tom@tromey.com>

PR gdb/18624:
* coffread.c (coff_symtab_read): Use scoped_free_pendings.
gdb/ChangeLog
gdb/coffread.c