ALSA: hda: Release controller display power during shutdown/reboot
authorImre Deak <imre.deak@intel.com>
Wed, 23 Jun 2021 13:46:00 +0000 (16:46 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 23 Jun 2021 14:28:02 +0000 (16:28 +0200)
commit472e18f63c425dda97b888f40f858ea54e3efc17
tree40bbb5c640fc320401a94509bea3bac4bd734297
parent0ac05b25c3dd8299204ae9d50c1c2f7f05eef08f
ALSA: hda: Release controller display power during shutdown/reboot

Make sure the HDA driver's display power reference is released during
shutdown/reboot.

During the shutdown/reboot sequence the pci device core calls the
pm_runtime_resume handler for all devices before calling the driver's
shutdown callback and so the HDA driver's runtime resume callback will
acquire a display power reference (on HSW/BDW). This triggers a power
reference held WARN on HSW/BDW in the i915 driver's subsequent shutdown
handler, which expects all display power references to be released by
that time.

Since the HDA controller is stopped in the shutdown handler in any case,
let's follow here the same sequence as the one during runtime suspend.
This will also reset the HDA link and drop the display power reference,
getting rid of the above WARN.

Tested on HSW.

v2:
- Fix the build for CONFIG_PM=n (Takashi)
- s/__azx_runtime_suspend/azx_shutdown_chip/

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3618
References: https://lore.kernel.org/lkml/cea1f9a-52e0-b83-593d-52997fe1aaf6@er-systems.de
Reported-and-tested-by: Thomas Voegtle <tv@lio96.de>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://lore.kernel.org/r/20210623134601.2128663-1-imre.deak@intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c