[OpenMP] Deprecate the old driver for OpenMP offloading
authorJoseph Huber <jhuber6@vols.utk.edu>
Wed, 24 Aug 2022 14:16:08 +0000 (09:16 -0500)
committerJoseph Huber <jhuber6@vols.utk.edu>
Fri, 26 Aug 2022 18:47:09 +0000 (13:47 -0500)
commit47166968db5c5c677bda996e0c5e40e94d8ef09f
treeafa232ebc3cca7e612c16d1df71a420fd5bbfa49
parenteabfaced504a6fa301c03b8d2f284960d9a84cb5
[OpenMP] Deprecate the old driver for OpenMP offloading

Recently OpenMP has transitioned to using the "new" driver which
primarily merges the device and host linking phases into a single
wrapper that handles both at the same time. This replaced a few tools
that were only used for OpenMP offloading, such as the
`clang-offload-wrapper` and `clang-nvlink-wrapper`. The new driver
carries some marked benefits compared to the old driver that is now
being deprecated. Things like device-side LTO, static library
support, and more compatible tooling. As such, we should be able to
completely deprecate the old driver, at least for OpenMP. The old driver
support will still exist for CUDA and HIP, although both of these can
currently be compiled on Linux with `--offload-new-driver` to use the new
method.

Note that this does not deprecate the `clang-offload-bundler`, although
it is unused by OpenMP now, it is still used by the HIP toolchain both
as their device binary format and object format.

When I proposed deprecating this code I heard some vendors voice
concernes about needing to update their code in their fork. They should
be able to just revert this commit if it lands.

Reviewed By: jdoerfert, MaskRay, ye-luo

Differential Revision: https://reviews.llvm.org/D130020
43 files changed:
clang/include/clang/Driver/Action.h
clang/include/clang/Driver/ToolChain.h
clang/lib/Driver/Action.cpp
clang/lib/Driver/Driver.cpp
clang/lib/Driver/ToolChain.cpp
clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
clang/lib/Driver/ToolChains/Clang.cpp
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Driver/ToolChains/Cuda.h
clang/test/Driver/amdgpu-openmp-system-arch.c [deleted file]
clang/test/Driver/amdgpu-openmp-toolchain-new.c [deleted file]
clang/test/Driver/amdgpu-openmp-toolchain.c
clang/test/Driver/clang-offload-wrapper.c [deleted file]
clang/test/Driver/fat_archive_amdgpu.cpp [deleted file]
clang/test/Driver/fat_archive_nvptx.cpp [deleted file]
clang/test/Driver/openmp-offload-gpu-new.c [deleted file]
clang/test/Driver/openmp-offload-gpu.c
clang/test/Driver/openmp-offload.c
clang/tools/CMakeLists.txt
clang/tools/clang-nvlink-wrapper/CMakeLists.txt [deleted file]
clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp [deleted file]
clang/tools/clang-offload-wrapper/CMakeLists.txt [deleted file]
clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp [deleted file]
openmp/libomptarget/CMakeLists.txt
openmp/libomptarget/test/lit.cfg
openmp/libomptarget/test/mapping/data_member_ref.cpp
openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers.cpp
openmp/libomptarget/test/mapping/declare_mapper_nested_mappers.cpp
openmp/libomptarget/test/mapping/lambda_by_value.cpp
openmp/libomptarget/test/mapping/lambda_mapping.cpp
openmp/libomptarget/test/mapping/map_back_race.cpp
openmp/libomptarget/test/mapping/ompx_hold/struct.c
openmp/libomptarget/test/offloading/bug49021.cpp
openmp/libomptarget/test/offloading/bug49334.cpp
openmp/libomptarget/test/offloading/bug49779.cpp
openmp/libomptarget/test/offloading/bug51781.c
openmp/libomptarget/test/offloading/host_as_target.c
openmp/libomptarget/test/offloading/memory_manager.cpp
openmp/libomptarget/test/offloading/parallel_offloading_map.cpp
openmp/libomptarget/test/offloading/static_linking.c
openmp/libomptarget/test/offloading/taskloop_offload_nowait.cpp
openmp/libomptarget/test/unified_shared_memory/api.c