broadcom/compiler: return NULL if we fail to register allocate
authorAlejandro Piñeiro <apinheiro@igalia.com>
Wed, 24 May 2023 08:32:59 +0000 (10:32 +0200)
committerMarge Bot <emma+marge@anholt.net>
Wed, 24 May 2023 14:19:12 +0000 (14:19 +0000)
commit470b8567a52f4581510e19643e8c26d8b7458bc3
tree4f8f92bdc130c60479302eb1e4d2db511b8d8fdb
parent83cd7d23a26d3cbd1af4805e95c4e588950f0fd5
broadcom/compiler: return NULL if we fail to register allocate

Right now if we fail to register allocate, we return the qpu_insts
that we had at that point, even if the driver can't really use it.

Also v3dv_pipeline was already assuming that it would return NULL on
failure, returning VK_ERROR_UNKNOWN on that case.

This allows CTS tests with a lot of pressure, that regress now and
then to not being able to allocate, to finish with an error, instead
of blocking forever. For example:
dEQP-VK.graphicsfuzz.spv-stable-maze-flatten-copy-composite

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23203>
src/broadcom/compiler/vir.c