drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()
authorYuan Can <yuancan@huawei.com>
Fri, 4 Nov 2022 06:45:12 +0000 (06:45 +0000)
committerPaul Cercueil <paul@crapouillou.net>
Fri, 4 Nov 2022 11:04:27 +0000 (11:04 +0000)
commit47078311b8efebdefd5b3b2f87e2b02b14f49c66
treef44fa93174ac8e13c292890ea45fdf2dfe47b974
parenta82f30b04c6aaefe62cbbfd297e1bb23435b6b3a
drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

A problem about modprobe ingenic-drm failed is triggered with the following
log given:

 [  303.561088] Error: Driver 'ingenic-ipu' is already registered, aborting...
 modprobe: ERROR: could not insert 'ingenic_drm': Device or resource busy

The reason is that ingenic_drm_init() returns platform_driver_register()
directly without checking its return value, if platform_driver_register()
failed, it returns without unregistering ingenic_ipu_driver_ptr, resulting
the ingenic-drm can never be installed later.
A simple call graph is shown as below:

 ingenic_drm_init()
   platform_driver_register() # ingenic_ipu_driver_ptr are registered
   platform_driver_register()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without unregister ingenic_ipu_driver_ptr

Fixing this problem by checking the return value of
platform_driver_register() and do platform_unregister_drivers() if
error happened.

Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20221104064512.8569-1-yuancan@huawei.com
drivers/gpu/drm/ingenic/ingenic-drm-drv.c