ALSA: hda/hdmi: packet buffer index must be set before reading value
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Fri, 11 Dec 2020 13:16:13 +0000 (15:16 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Dec 2020 13:25:44 +0000 (14:25 +0100)
commit46c3bbd9827952f92e250fa6ee30a797a4c4e17e
treea17249f7ed6477e76d8dc7fabcb00de3b41c5632
parent13b1f8aa6569060480dc747e45741581dbc0cfc2
ALSA: hda/hdmi: packet buffer index must be set before reading value

The check for infoframe transmit status in hdmi_infoframe_uptodate()
makes the assumption that packet buffer index is set to zero.

Align code with specification and explicitly set the index before
AC_VERB_GET_HDMI_DIP_XMIT. The packet index setting affects both
DIP-Data and DIP-XmitCtrl verbs.

There are no known cases where the old implementation has caused driver
to work incorrectly. This change is purely based on code review against
the specification (HDA spec rev1.0a).

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20201211131613.3271407-1-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_hdmi.c