sfc: Only use TX push if a single descriptor is to be written
authorBen Hutchings <bhutchings@solarflare.com>
Wed, 27 Feb 2013 16:50:38 +0000 (16:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Mar 2013 19:12:04 +0000 (12:12 -0700)
commit46a84dbc74f10d2f855758d809a0b21592bd2b8e
treeea81fff5f3a2fcfc24f3ef4bb73d40b901238d2a
parent70a3336df60074b29ac3b546d8fccfbcf7831e95
sfc: Only use TX push if a single descriptor is to be written

[ Upstream commit fae8563b25f73dc584a07bcda7a82750ff4f7672 ]

Using TX push when notifying the NIC of multiple new descriptors in
the ring will very occasionally cause the TX DMA engine to re-use an
old descriptor.  This can result in a duplicated or partly duplicated
packet (new headers with old data), or an IOMMU page fault.  This does
not happen when the pushed descriptor is the only one written.

TX push also provides little latency benefit when a packet requires
more than one descriptor.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/sfc/nic.c