iio: addac: stx104: Use define rather than hardcoded limit for write val
authorWilliam Breathitt Gray <william.gray@linaro.org>
Thu, 6 Apr 2023 14:40:12 +0000 (10:40 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 10 Apr 2023 11:26:33 +0000 (12:26 +0100)
commit46a4cac7f841a2a2cb397bcb2fd24324004c853e
treeb6810c854dcf84e1bd53c663407159ee5d1dfda4
parent4f9b80aefb9e2f542a49d9ec087cf5919730e1dd
iio: addac: stx104: Use define rather than hardcoded limit for write val

The DAC register is 16 bits wide, so the value passed by write_raw()
should be checked against that limit. Rather than hardcoding the 16-bit
maximum value limit, use a define to improve readability and make the
intention of the code clearer. The explicit cast is also avoided by
instead explicitly checking for negative values.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
Link: https://lore.kernel.org/r/4c9f4f1b4a270d133be70c82a091351b531b5e3e.1680790580.git.william.gray@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/addac/stx104.c