Revert "pulsesink: uncork if needed upon commit"
authorJan Schmidt <jan@centricular.com>
Fri, 15 Apr 2016 16:17:26 +0000 (02:17 +1000)
committerJan Schmidt <jan@centricular.com>
Fri, 15 Apr 2016 16:21:14 +0000 (02:21 +1000)
commit46a3c9ac8b2f8182ef8f211f4be09a67e4d42a61
tree2243b5c2d7eae9fb0c015217c9704d2335538216
parentc36930535d5a20476aaa403477c51c76640a45a1
Revert "pulsesink: uncork if needed upon commit"

This reverts commit 0dd46accf6d282ff07065852bd91c85c78af3394.

With some audiosinks, starting the ringbuffer on the first commit
causes audio glitches at startup by starting to output segments
from the ringbuffer before it has been filled / fully prerolled. This
doesn't usually happen with pulsesink because we map the pulseaudio
ringbuffer directly, but we should keep things consistent with
other sinks with regards to startup latency, plus it gives more
headway to avoid glitching, should the initial 2nd segment take
more than 10ms to generate.

https://bugzilla.gnome.org/show_bug.cgi?id=657076
ext/pulse/pulsesink.c