projects / platform / upstream / dotnet / runtime.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c563917) | patch
Delete ClientWebSocket's event source (#38870)
authorStephen Toub <stoub@microsoft.com>
Wed, 8 Jul 2020 18:18:32 +0000 (14:18 -0400)
committerGitHub <noreply@github.com>
Wed, 8 Jul 2020 18:18:32 +0000 (14:18 -0400)
commit46600ec2a4b966d51fc25f6960db3ce114ef5246
tree1544d966a1bc597115dcedcc3284f7aae44e6b46tree | snapshot
parentc5639174bfa94fda89096d5da77fa5b931bcdd22commit | diff
Delete ClientWebSocket's event source (#38870)

It's raising a single event for failed connects, and actual networking-related failures for failed connects will already be logged by the underlying API used.

By getting rid of the catch and rethrow, we can also avoid an extra layer of async state machine on connect.
src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj diff | blob | history
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs diff | blob | history
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/NetEventSource.WebSockets.cs [deleted file] blob | history
src/libraries/System.Net.WebSockets.Client/tests/LoggingTest.cs [deleted file] blob | history
src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj diff | blob | history
Domain: Dotnet / Core;