Input: atmel_mxt_ts - disable IRQ across suspend
authorEvan Green <evgreen@chromium.org>
Wed, 2 Oct 2019 21:00:21 +0000 (14:00 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 2 Oct 2019 21:02:31 +0000 (14:02 -0700)
commit463fa44eec2fef50d111ed0199cf593235065c04
treeb84f11dfdf81a30dbf32522f5c566485efa823d5
parent410f25de467ee94c1a577c6ee7370c37b376c17c
Input: atmel_mxt_ts - disable IRQ across suspend

Across suspend and resume, we are seeing error messages like the following:

atmel_mxt_ts i2c-PRP0001:00: __mxt_read_reg: i2c transfer failed (-121)
atmel_mxt_ts i2c-PRP0001:00: Failed to read T44 and T5 (-121)

This occurs because the driver leaves its IRQ enabled. Upon resume, there
is an IRQ pending, but the interrupt is serviced before both the driver and
the underlying I2C bus have been resumed. This causes EREMOTEIO errors.

Disable the IRQ in suspend, and re-enable it on resume. If there are cases
where the driver enters suspend with interrupts disabled, that's a bug we
should fix separately.

Signed-off-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/atmel_mxt_ts.c