Fix crash with -D_GLIBCXX_DEBUG
authorTom Tromey <tom@tromey.com>
Fri, 20 Jul 2018 03:10:09 +0000 (21:10 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 30 Jul 2018 14:33:26 +0000 (08:33 -0600)
commit463c08d160e55d6eaf0f9bc3729781ce90f4de3f
tree3c98c35b84280fc2c1596465bb9bfc4e8f2ceac5
parentdba7455e76f87abe81cc9e4e9b1f979c1da02846
Fix crash with -D_GLIBCXX_DEBUG

I noticed a buildbot failure where gdb crashed in info-os.exp, when
compiled with -D_GLIBCXX_DEBUG:

    (gdb) info os procgroups
    /usr/include/c++/7/bits/stl_algo.h:4834:
    Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).
    Objects involved in the operation:
iterator::value_type "< operator type" {
  type = pid_pgid_entry;
}

The bug here is that pid_pgid_entry::operator< violates the C++
irreflexivity rule; that is, that an object cannot be less than
itself.

Tested locally by re-running info-os.exp.

gdb/ChangeLog
2018-07-30  Tom Tromey  <tom@tromey.com>

* nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
irreflexivity violation.
gdb/ChangeLog
gdb/nat/linux-osdata.c