syscall_user_dispatch: Untag selector address before access_ok()
authorGregory Price <gourry.memverge@gmail.com>
Fri, 7 Apr 2023 17:18:32 +0000 (13:18 -0400)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 16 Apr 2023 12:23:07 +0000 (14:23 +0200)
commit463b7715e7ce367fce89769c5d85e31595715ee1
treefd74da6fa4a4de6fc0c3e7d888ee221ce8f72948
parent43360686328b1f4b7d9dcc883ee9243ad7c16fae
syscall_user_dispatch: Untag selector address before access_ok()

To support checkpoint/restart, ptrace must be able to set the selector
of the tracee.  The selector is a user pointer that may be subject to
memory tagging extensions on some architectures (namely ARM MTE).

access_ok() clears memory tags for tagged addresses if the current task has
memory tagging enabled.

This obviously fails when ptrace modifies the selector of a tracee when
tracer and tracee do not have the same memory tagging enabled state.

Solve this by untagging the selector address before handing it to
access_ok(), like other ptrace functions which modify tracee pointers do.

Obviously a tracer can set an invalid selector address for the tracee, but
that's independent of tagging and a general capability of the tracer.

Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Gregory Price <gregory.price@memverge.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/all/ZCWXE04nLZ4pXEtM@arm.com/
Link: https://lore.kernel.org/r/20230407171834.3558-3-gregory.price@memverge.com
kernel/entry/syscall_user_dispatch.c