gdb: Restore selected frame in print_frame_local_vars
authorAndrew Burgess <andrew.burgess@embecosm.com>
Fri, 18 May 2018 16:45:16 +0000 (17:45 +0100)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Thu, 24 May 2018 17:01:31 +0000 (18:01 +0100)
commit45f25d6c83c31a48a01ef8293bb3978f5e58e653
tree3eddbff0a9ff77faa031e6180f985b60774583a7
parentd9f6d7f8b636a2b32004273143d72a77d82b40de
gdb: Restore selected frame in print_frame_local_vars

PR gdb/23203 reports 'bt full' causing the currently selected frame to
change, this issue is fixed in this commit.

Add a new class scoped_restore_selected_frame that saves and restores
the selected frame.  Make use of this in print_frame_local_vars to
restore the selected frame on exit.

gdb/ChangeLog:

PR gdb/23203
* frame.c
(scoped_restore_selected_frame::scoped_restore_selected_frame):
Define.
(scoped_restore_selected_frame::~scoped_restore_selected_frame):
Define.
* frame.h (class scoped_restore_selected_frame): New class.
* stack.c (print_frame_local_vars): Remove catching and rethrowing
of any exception, use scoped_restore_selected_frame to restore the
frame instead.

gdb/testsuite/ChangeLog:

PR gdb/23203
* gdb.base/bt-selected-frame.c: New file.
* gdb.base/bt-selected-frame.exp: New file.
* lib/gdb.exp (get_current_frame_number): New function.
gdb/ChangeLog
gdb/frame.c
gdb/frame.h
gdb/stack.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/bt-selected-frame.c [new file with mode: 0644]
gdb/testsuite/gdb.base/bt-selected-frame.exp [new file with mode: 0644]
gdb/testsuite/lib/gdb.exp