Recommit r308327 3rd time: Add a warning for missing
authorAlex Lorenz <arphaman@gmail.com>
Fri, 28 Jul 2017 14:41:21 +0000 (14:41 +0000)
committerAlex Lorenz <arphaman@gmail.com>
Fri, 28 Jul 2017 14:41:21 +0000 (14:41 +0000)
commit45b40147117668ce65bff4f6a240bdae4ad4bf7d
treeeb228c2894e133a2cf86bca834e490f38f4aaf3b
parente42b44b87d730717231193730edbbcfdf88c9466
Recommit r308327 3rd time: Add a warning for missing
'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files

The second recommit (r309106) was reverted because the "non-default #pragma
pack value chages the alignment of struct or union members in the included file"
warning proved to be too aggressive for external projects like Chromium
(https://bugs.chromium.org/p/chromium/issues/detail?id=749197). This recommit
makes the problematic warning a non-default one, and gives it the
-Wpragma-pack-suspicious-include warning option.

The first recommit (r308441) caused a "non-default #pragma pack value might
change the alignment of struct or union members in the included file" warning
in LLVM itself. This recommit tweaks the added warning to avoid warnings for
#includes that don't have any records that are affected by the non-default
alignment. This tweak avoids the previously emitted warning in LLVM.

Original message:

This commit adds a new -Wpragma-pack warning. It warns in the following cases:

- When a translation unit is missing terminating #pragma pack (pop) directives.
- When entering an included file if the current alignment value as determined
  by '#pragma pack' directives is different from the default alignment value.
- When leaving an included file that changed the state of the current alignment
  value.

rdar://10184173

Differential Revision: https://reviews.llvm.org/D35484

llvm-svn: 309386
22 files changed:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Lex/PPCallbacks.h
clang/include/clang/Sema/Sema.h
clang/include/clang/Serialization/ASTReader.h
clang/lib/Parse/ParsePragma.cpp
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaAttr.cpp
clang/lib/Serialization/ASTReader.cpp
clang/lib/Serialization/ASTWriter.cpp
clang/test/OpenMP/declare_simd_messages.cpp
clang/test/PCH/pragma-pack.c
clang/test/PCH/suspicious-pragma-pack.c [new file with mode: 0644]
clang/test/Parser/pragma-options.c
clang/test/Parser/pragma-options.cpp
clang/test/Parser/pragma-pack.c
clang/test/Sema/Inputs/pragma-pack1.h [new file with mode: 0644]
clang/test/Sema/Inputs/pragma-pack2.h [new file with mode: 0644]
clang/test/Sema/pragma-pack.c
clang/test/Sema/suspicious-pragma-pack.c [new file with mode: 0644]
clang/test/SemaObjC/Inputs/empty.h [new file with mode: 0644]
clang/test/SemaObjC/suspicious-pragma-pack.m [new file with mode: 0644]