ASoC: soc-compress: lock pcm_mutex to resolve lockdep error
authorGyeongtaek Lee <gt82.lee@samsung.com>
Wed, 7 Apr 2021 04:14:04 +0000 (13:14 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 9 Apr 2021 12:39:44 +0000 (13:39 +0100)
commit45475bf60cc1d42da229a0aa757180c88bab8d22
tree200f01e52ffe55f5b3d0f1874dfe916a6b12b095
parent3e075e842899779bd321520a3524a278442467d0
ASoC: soc-compress: lock pcm_mutex to resolve lockdep error

If panic_on_warn=1 is added in bootargs and compress offload playback with
DPCM is started, kernel panic would be occurred because rtd->card->pcm_mutex
isn't held in soc_compr_open_fe() and soc_compr_free_fe() and it generates
lockdep warning in the following code.

void snd_soc_runtime_action(struct snd_soc_pcm_runtime *rtd,
    int stream, int action)
{
struct snd_soc_dai *dai;
int i;

lockdep_assert_held(&rtd->card->pcm_mutex);

To prevent lockdep warning but minimize side effect by adding mutex,
pcm_mutex is held just before snd_soc_runtime_activate() and
snd_soc_runtime_deactivate() and is released right after them.

Signed-off-by: Gyeongtaek Lee <gt82.lee@samsung.com>
Link: https://lore.kernel.org/r/1891546521.01617772502282.JavaMail.epsvc@epcpadp3
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-compress.c