projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6c27376) | patch
Expand -Wlogical-not-parentheses to also fire on `!x & A`.
authorNico Weber <nicolasweber@gmx.de>
Thu, 27 Oct 2016 16:32:06 +0000 (16:32 +0000)
committerNico Weber <nicolasweber@gmx.de>
Thu, 27 Oct 2016 16:32:06 +0000 (16:32 +0000)
commit44f6f2ee423325e6157846593a74e5ed01ab3062
tree7bb39737f18a1789a24d402a2e9e3f4f24109c1dtree | snapshot
parent6c273763a366de3b1e22348b638795795fb7e005commit | diff
Expand -Wlogical-not-parentheses to also fire on `!x & A`.

This is a misspelling of the intended !(x & A) negated bit test that happens in
practice every now and then.

I ran this on Chromium and all its dependencies, and it fired 0 times -- no
false or true positives, but it would've caught a bug in an in-progress change
that had to be caught by a Visual Studio warning instead.

https://reviews.llvm.org/D26035

llvm-svn: 285310
clang/include/clang/Basic/DiagnosticSemaKinds.td diff | blob | history
clang/include/clang/Sema/Sema.h diff | blob | history
clang/lib/Sema/SemaExpr.cpp diff | blob | history
clang/test/SemaCXX/warn-logical-not-compare.cpp diff | blob | history
Domain: System / Toolchain;