serial: sh-sci: Do not start transfers from sci_startup()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 24 Jun 2016 14:59:13 +0000 (16:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2016 16:09:53 +0000 (09:09 -0700)
commit44763d3d301a13523186731b4797b181c78fe8b4
tree18b67fe756d1aa42028ce90e05277fc6f7904ebc
parentac8305cd16ea2c35084ceb5cdf36f5a90c275c3a
serial: sh-sci: Do not start transfers from sci_startup()

FIFO reset is done in sci_reset(), called from sci_set_termios(), while
sci_start_tx() and sci_start_rx() are called before, from sci_startup().
However, starting transfers before the UART's FIFOs have been reset may
cause reading of stale data.

Remove the calls to sci_start_tx() and sci_start_rx() from sci_startup()
to fix this.

Transfers are still started when needed:
  - sci_start_rx() is called from sci_set_termios() after FIFO reset, if
    the CREAD flag is set,
  - sci_start_tx() is called from uart_change_speed() immediately
    thereafter, if transmission is enabled.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c