ARM: dts: qcom: ipq4019: Fix MSI IRQ type
authorNiklas Cassel <niklas.cassel@linaro.org>
Thu, 24 Jan 2019 13:00:47 +0000 (14:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Sep 2019 06:22:11 +0000 (08:22 +0200)
commit445a78ea3f906518cb85163b71dad3502a91b779
tree46904b69984e19fc45fb111256a8bdd5d04c63e9
parentdf1216d8bc866336e393240466c875a0bac4049f
ARM: dts: qcom: ipq4019: Fix MSI IRQ type

[ Upstream commit 97131f85c08e024df49480ed499aae8fb754067f ]

The databook clearly states that the MSI IRQ (msi_ctrl_int) is a level
triggered interrupt.

The msi_ctrl_int will be high for as long as any MSI status bit is set,
thus the IRQ type should be set to IRQ_TYPE_LEVEL_HIGH, causing the
IRQ handler to keep getting called, as long as any MSI status bit is set.

A git grep shows that ipq4019 is the only SoC using snps,dw-pcie that has
configured this IRQ incorrectly.

Not having the correct IRQ type defined will cause us to lose interrupts,
which in turn causes timeouts in the PCIe endpoint drivers.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/qcom-ipq4019.dtsi