xfs: cleanup xfs_rename error handling
authorDave Chinner <dchinner@redhat.com>
Wed, 25 Mar 2015 03:05:43 +0000 (14:05 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 25 Mar 2015 03:05:43 +0000 (14:05 +1100)
commit445883e8133975fe8d555610c70c1c4c501f0bf8
tree6f1ecf9746c65f6c31a0060812d8cf6f1df90c74
parent95afcf5c7bca93fb84d260f70c304f35ef4c3114
xfs: cleanup xfs_rename error handling

The jump labels are ambiguous and unclear and some of the error
paths are used inconsistently. Rules for error jumps are:

- use out_trans_cancel for unmodified transaction context
- use out_bmap_cancel on ENOSPC errors
- use out_trans_abort when transaction is likely to be dirty.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_inode.c