dm bufio: fix memleak when using a dm_buffer's inline bio
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 26 Nov 2014 01:45:15 +0000 (17:45 -0800)
committerMike Snitzer <snitzer@redhat.com>
Mon, 1 Dec 2014 16:31:17 +0000 (11:31 -0500)
commit445559cdcb98a141f5de415b94fd6eaccab87e6d
tree346a5f609e84804eaa045fcc4583e0c9fda3c467
parentf824a2af3dfbbb766c02e19df21f985bceadf0ee
dm bufio: fix memleak when using a dm_buffer's inline bio

When dm-bufio sets out to use the bio built into a struct dm_buffer to
issue an IO, it needs to call bio_reset after it's done with the bio
so that we can free things attached to the bio such as the integrity
payload.  Therefore, inject our own endio callback to take care of
the bio_reset after calling submit_io's end_io callback.

Test case:
1. modprobe scsi_debug delay=0 dif=1 dix=199 ato=1 dev_size_mb=300
2. Set up a dm-bufio client, e.g. dm-verity, on the scsi_debug device
3. Repeatedly read metadata and watch kmalloc-192 leak!

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-bufio.c