drm/client: Prevent NULL dereference in drm_client_buffer_delete()
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Sun, 30 Oct 2022 15:44:12 +0000 (18:44 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Wed, 2 Nov 2022 10:53:57 +0000 (13:53 +0300)
commit444bbba708e804c13ad757068d1cb31ed6460754
tree14030bfb4b2a36beeb838b3d75766b54b4596aa5
parentd3292daee319581d0a502fcd8ef3c3c285a1750a
drm/client: Prevent NULL dereference in drm_client_buffer_delete()

The drm_gem_vunmap() will crash with a NULL dereference if the passed
object pointer is NULL. It wasn't a problem before we added the locking
support to drm_gem_vunmap function because the mapping argument was always
NULL together with the object. Make drm_client_buffer_delete() to check
whether GEM is NULL before trying to unmap the GEM, it will happen on
framebuffer creation error.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://lore.kernel.org/dri-devel/Y1kFEGxT8MVlf32V@kili/
Fixes: 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221030154412.8320-3-dmitry.osipenko@collabora.com
drivers/gpu/drm/drm_client.c