drm/amd/display: Fix possible NULL dereference in dc_dmub_srv_cmd_run_list()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Wed, 26 Apr 2023 19:24:12 +0000 (12:24 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 13:25:59 +0000 (09:25 -0400)
commit44407010ce7f524e4f68aa25f9250a9cf9e4410c
tree1bbe2a496e901593b74ecd27f1d111e94fca2f20
parent8fa76350587b6deb8a95d83f9cb23ce7599587b5
drm/amd/display: Fix possible NULL dereference in dc_dmub_srv_cmd_run_list()

We have a NULL check for 'dc_dmub_srv' in dc_dmub_srv_cmd_run_list()
but we are dereferencing it before checking.

Fix this moving the dereference next to NULL check.

This issue is found with Smatch(static analysis tool).

Fixes: e97cc04fe0fb ("drm/amd/display: refactor dmub commands into single function")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c