Remove the per-connection link cache
authorSimon McVittie <simon.mcvittie@collabora.co.uk>
Fri, 29 Apr 2011 14:08:53 +0000 (15:08 +0100)
committerSimon McVittie <simon.mcvittie@collabora.co.uk>
Thu, 28 Jul 2011 17:23:49 +0000 (18:23 +0100)
commit4437ddb4731092985182bfe2f83ef2e9452d92e5
tree92804d5fe2a8163113d09b1ac455781a0503f314
parentaea47abba5e036d8767f0f04faa1c7dc2a9a1b51
Remove the per-connection link cache

With fd.o#34393 fixed, retaking the lock to cache unused links
significantly adds to locking overhead (-18% throughput in a synthetic
benchmark on an ARM device). The cache is also unlimited in size, and
probably contributes to memory growth and fragmentation by not being
under the system malloc's control.

Fixing fd.o #34393, but also dropping this cache entirely, turns out to
lead to a 5% increase in throughput on the same synthetic benchmark.

Reviewed-by: Colin Walters <walters@verbum.org>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34393
dbus/dbus-connection.c