bpf: Reliably preserve btf_trace_xxx types
authorAndrii Nakryiko <andriin@fb.com>
Sun, 1 Mar 2020 08:10:43 +0000 (00:10 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 3 Mar 2020 00:49:55 +0000 (16:49 -0800)
commit441420a1f0b3031f228453697406c86f110e59d4
treed223a75dcdd795660206c0be228148de5c1aa944
parent82dbbfc822cd7230c657b49da6557c8bf2f6621d
bpf: Reliably preserve btf_trace_xxx types

btf_trace_xxx types, crucial for tp_btf BPF programs (raw tracepoint with
verifier-checked direct memory access), have to be preserved in kernel BTF to
allow verifier do its job and enforce type/memory safety. It was reported
([0]) that for kernels built with Clang current type-casting approach doesn't
preserve these types.

This patch fixes it by declaring an anonymous union for each registered
tracepoint, capturing both struct bpf_raw_event_map information, as well as
recording btf_trace_##call type reliably. Structurally, it's still the same
content as for a plain struct bpf_raw_event_map, so no other changes are
necessary.

  [0] https://github.com/iovisor/bcc/issues/2770#issuecomment-591007692

Fixes: e8c423fb31fa ("bpf: Add typecast to raw_tracepoints to help BTF generation")
Reported-by: Wenbo Zhang <ethercflow@gmail.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20200301081045.3491005-2-andriin@fb.com
include/trace/bpf_probe.h