soundwire: stream: Add specific prep/deprep commands to port_prep callback
authorStefan Binding <sbinding@opensource.cirrus.com>
Fri, 27 Jan 2023 16:51:04 +0000 (16:51 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 31 Jan 2023 12:10:45 +0000 (12:10 +0000)
commit43f1a7f905fcc796620c6488a7098068a05484ca
tree8bb540ffb176c5722e27a8b4424342b893942c79
parent67aa59afcf3f15183811157b7742762ed5ab416f
soundwire: stream: Add specific prep/deprep commands to port_prep callback

Currently, port_prep callback only has commands for PRE_PREP, PREP,
and POST_PREP, which doesn't directly say whether this is for a
prepare or deprepare call. Extend the command list enum to say
whether the call is for prepare or deprepare aswell.

Also remove SDW_OPS_PORT_PREP from sdw_port_prep_ops as this is unused,
and update this enum to be simpler and more consistent with enum
sdw_clk_stop_type.

Note: Currently, the only users of SDW_OPS_PORT_POST_PREP are codec
drivers sound/soc/codecs/wsa881x.c and sound/soc/codecs/wsa883x.c, both
of which seem to assume that POST_PREP only occurs after a prepare,
even though it would also have occurred after a deprepare. Since it
doesn't make sense to mark the port prepared after a deprepare, changing
the enum to separate PORT_DEPREP from PORT_PREP should make the check
for PORT_PREP in those drivers be more logical.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20230127165111.3010960-2-sbinding@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/soundwire/stream.c
include/linux/soundwire/sdw.h