2010-12-29 Martin Robinson <mrobinson@igalia.com>
authormrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Dec 2010 22:20:51 +0000 (22:20 +0000)
committermrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Dec 2010 22:20:51 +0000 (22:20 +0000)
commit43e80e2f18c502223a15e45f6200b28ca69bfd2a
tree7f26c1d886d774fd69bcc2da190a007af064a4a3
parentf8888e785f11a0747d86687c7239ad3b00437a00
2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Sam Weinig.

        JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
        https://bugs.webkit.org/show_bug.cgi?id=51722

        Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
        methods the fastcall calling convention, which leads to runtime errors when they are
        called from C++. Also remove a bit of unnecessary code duplication.

        No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::getDataViewMember): Remove duplicated code.
        (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
        (WebCore::JSDataView::getUint8): Ditto.
        (WebCore::JSDataView::getFloat32): Ditto.
        (WebCore::JSDataView::getFloat64): Ditto.
        (WebCore::setDataViewMember): Remove duplicated code.
        (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
        (WebCore::JSDataView::setUint8): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/bindings/js/JSDataViewCustom.cpp