SUNRPC/cache: Fix unsafe traverse caused double-free in cache_purge
authorYihao Wu <wuyihao@linux.alibaba.com>
Sun, 5 Apr 2020 17:57:22 +0000 (01:57 +0800)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 13 Apr 2020 14:28:21 +0000 (10:28 -0400)
commit43e33924c38e8faeb0c12035481cb150e602e39d
tree2874c7b0edaf651e4804e165edf5a8c3789ca2f8
parente1e8399eee72e9d5246d4d1bcacd793debe34dd3
SUNRPC/cache: Fix unsafe traverse caused double-free in cache_purge

Deleting list entry within hlist_for_each_entry_safe is not safe unless
next pointer (tmp) is protected too. It's not, because once hash_lock
is released, cache_clean may delete the entry that tmp points to. Then
cache_purge can walk to a deleted entry and tries to double free it.

Fix this bug by holding only the deleted entry's reference.

Suggested-by: NeilBrown <neilb@suse.de>
Signed-off-by: Yihao Wu <wuyihao@linux.alibaba.com>
Reviewed-by: NeilBrown <neilb@suse.de>
[ cel: removed unused variable ]
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/cache.c