team: Fix double free in error path
authorArkadi Sharshevsky <arkadis@mellanox.com>
Thu, 8 Mar 2018 10:42:10 +0000 (12:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Mar 2018 16:10:42 +0000 (18:10 +0200)
commit43d8f3c5d3ad77329545f5464c2b7e08074eea1a
treeb224c6f2ed31d22c380df1279d4a3c64e2e3c842
parent329f4710f89c028d5a8904040af913dfc5727362
team: Fix double free in error path

[ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ]

The __send_and_alloc_skb() receives a skb ptr as a parameter but in
case it fails the skb is not valid:
- Send failed and released the skb internally.
- Allocation failed.

The current code tries to release the skb in case of failure which
causes redundant freeing.

Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/team/team.c