projects / platform / upstream / dotnet / runtime.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3665779) | patch
Remove setting ICUCORE for macOS in System.Globalization.Native CMake config (#39900)
authorAlexander Köplinger <alex.koeplinger@outlook.com>
Fri, 24 Jul 2020 20:31:59 +0000 (22:31 +0200)
committerGitHub <noreply@github.com>
Fri, 24 Jul 2020 20:31:59 +0000 (22:31 +0200)
commit43d558387cc0d48e45f9c1ca960f912c425c1fa1
tree1e86f0f193ebf62ba95f265368f4a005de520cbdtree | snapshot
parent36657793513070913cc7e95589a712aad3e8228fcommit | diff
Remove setting ICUCORE for macOS in System.Globalization.Native CMake config (#39900)

Follow-up to #39833.

We don't link against ICU on macOS but load it via `dlopen()` at runtime and compilation uses headers from homebrew.
That means `HAVE_SET_MAX_VARIABLE` and `HAVE_UDAT_STANDALONE_SHORTER_WEEKDAYS` will always be defined and we don't need the ICUCORE variable.

* PR feedback

Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
src/libraries/Native/Unix/System.Globalization.Native/CMakeLists.txt diff | blob | history
src/libraries/Native/Unix/System.Globalization.Native/configure.cmake diff | blob | history
Domain: Dotnet / Core;